Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up CompletionModel #4240

Merged
merged 2 commits into from
Dec 18, 2022
Merged

Clean up CompletionModel #4240

merged 2 commits into from
Dec 18, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Dec 18, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • Refactor CompletionModel
  • Use a shared mutex for CompletionModel's items mutex

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@pajlada pajlada changed the title chore/refactor completion model Clean up CompletionModel Dec 18, 2022
@pajlada pajlada merged commit 77852f0 into master Dec 18, 2022
@pajlada pajlada deleted the chore/refactor-completion-model branch December 18, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no changelog entry needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pajlada